Improve Location for Diagnostics #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasmewad
requested review from
sugmanue and
milesziemer
and removed request for
sugmanue
milesziemer
requested changes
Nov 5, 2024
|
|
||
| @ParameterizedTest | ||
| @MethodSource("contiguousRangeTestCases") | ||
| public void findsContiguousRange(SourceLocation input, Range expected) { |
There was a problem hiding this comment.
Can you add one where the source location is within whitespace? Not sure if that will ever be the case, but just in case.
There was a problem hiding this comment.
Sure. Can add that.
| String uri = workspace.getUri("main.smithy"); | ||
|
|
||
| List<Diagnostic> diagnostics = server.getFileDiagnostics(uri); | ||
| diagnostics.forEach(it -> System.out.println(it.toString())); |
There was a problem hiding this comment.
Fyi, can remove. Also in above test case
There was a problem hiding this comment.
Ahh yes, I removed it, but added it back by mistake lol.
yasmewad
force-pushed
the
diagnostic-improvements
branch
from
4b87258 to
3b1ea23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 76
What is changed?
Why is it necessary?
How was the change tested?
Screenshots of fix:
Fixed the
usediagnostic:Before:
After:
Fixed the diagnostics for incorrect members in a structure to not extend till start of line.
Before:
After:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.