Split up smithy-python #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors smithy-python into two packages: smithy-core and smithy-http, separating concerns to bring things more in line with the split other sdks are moving towards. This allows non-http clients to exclude http features altogether. It also makes awscrt and aiohttp into optional dependencies. Additionally, this attempts to break out async components into their own sections so that it will be more feasible to provide a sync client later on if necessary. Aside from ading in checks for the optional dependencies, the actual logic has not changed, only the locations of bits of code.
JordonPhillips
force-pushed
the
split-python-package
branch
from
5c5ea48 to
8669e6f
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #195 +/- ##
===========================================
- Coverage 94.64% 85.09% -9.56%
===========================================
Files 35 37 +2
Lines 1682 1134 -548
===========================================
- Hits 1592 965 -627
- Misses 90 169 +79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JordonPhillips
force-pushed
the
split-python-package
branch
from
12ffb6c to
551d41c
Compare
This renames the AWS python package to be in line with the new core packages, and updates its dependency to be on the new core package rather than the old one.
This removes the smithy-python package, which has been replaced by smithy-core and smithy-http
JordonPhillips
force-pushed
the
split-python-package
branch
from
551d41c to
562ca7f
Compare
nateprewitt
reviewed
Jan 5, 2024
Comment on lines
+1
to
+2
| aiohttp>=3.8.6,<3.10.0 | ||
| awscrt>=0.15,<1.0 |
There was a problem hiding this comment.
Is this for pants/testing? Ideally we'd be able to just install .[aiohttp] or .[awscrt] during testing to avoid specifying these ranges twice.
There was a problem hiding this comment.
Yes this is for pants since we had to stop sourcing deps from pyproject.toml
nateprewitt
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors smithy-python into two packages: smithy-core and smithy-http, separating concerns to bring things more in line with the split other sdks are moving towards. This allows non-http clients to exclude http features altogether. It also makes awscrt and aiohttp into optional dependencies.
Additionally, this attempts to break out async components into their own sections so that it will be more feasible to provide a sync client later on if necessary.
Another goal of this was to remove the weird
_privatedirectories we had going on.Aside from adding in checks for the optional dependencies, the actual logic has not changed, only the locations of bits of code.
There is one bit that needs resolving in a follow-up, which is making the default http client configurable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.