Add LICENSE and NOTICE files to generated client packages #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamRemis
requested changes
Aug 14, 2025
| /** | ||
| * This section controls the entire generated NOTICE | ||
| * | ||
| * <p>An integration may want to use this if they want to programmatically |
There was a problem hiding this comment.
Is there a reason we have the
tag here?
| private static void writeLicense( | ||
| GenerationContext context | ||
| ) { | ||
| context.writerDelegator().useFileWriter("LICENSE", writer -> { |
There was a problem hiding this comment.
How is this code AWS specific. I haven't tested it, so I could be wrong, but I think this will get generated for all SDKs, even non-AWS ones.
Does Smithy force a license that a customer must use? I would expect this to be a generic license that was smithy's default, then have that be overwritten by an AWS specific interceptor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LICENSEandNOTICEfiles are currently added manually added to the client packages (see example PR).This PR updates the code generator to generate an Apache-2.0
LICENSEfile andNOTICEfile withCopyright <currentYear> Amazon.com, Inc. or its affiliates. All Rights Reserved.at the top-level of the package.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.