proposal for improvement to have a better split between data and code #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with this patch, you have only to call the class bind,
alls subclasses will be called and the data is sourced
via hiera keys all appeded with 's' (see below)
few examples:
bind::configs:
'named.conf.servers':
content: |
server 192.168.1.1 {
keys { dns-axfr; };
};
bind::acls:
primaries:
address_match_list:
- 192.168.1.1
comment: powerdns
bind::keys:
dns-axfr:
algorithm: hmac-sha512
base64_secret: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa=='
bind::zone::secondarys:
example.net:
masters:
- 192.168.1.1
I'm hope this will make this module a bit more convinent and handy
Best greetings from Berlin
/holm
cr9427
changed the title
added 2 commits
December 9, 2024 19:24
|
Thanks for your PR. The spelling of some the new parameters looks odd. If you don't mind, I will update those. The PR seems to be in a draft state. Do you like to add something or can I merge the current state? |
|
Good morning Stefan,
I did some small changes and think with my last commit, this is now ready to merge, if you don't mind.
Best regaeds
/holm
|
smoeding
reviewed
Dec 27, 2024
| bind::zone::primaries: | ||
| example.com: | ||
| update_policy: grant nsupdate zonesub any | ||
| content: 'epp("profile/dynamic-zone-template.epp", $params)' |
There was a problem hiding this comment.
This won't work. The content of the zone file will be the given string and not the content of the template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this patch, you have only to call the class bind, alls subclasses will be called and the data is sourced via hiera keys all appeded with 's' (see below)
few examples:
bind::configs:
'named.conf.servers':
content: |
server 192.168.1.1 {
keys { dns-axfr; };
};
bind::acls:
primaries:
address_match_list:
- 192.168.1.1 comment: powerdns
bind::keys:
dns-axfr:
algorithm: hmac-sha512 base64_secret: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa=='
bind::zone::secondarys:
example.net:
masters:
- 192.168.1.1
I'm hope this will make this module a bit more convinent and handy
Best greetings from Berlin
/holm