Account for custom challenges with best of default checks

smogon · Nov 2, 2023 · b64f891 · b64f891
1 parent 463948f
commit b64f891
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/js/client-mainmenu.js b/js/client-mainmenu.js
@@ -896,7 +896,7 @@
 			buf += '<p><label class="label">Format:</label>' + this.renderFormats(format) + '</p>';
 			buf += '<p><label class="label">Team:</label>' + this.renderTeams(format) + '</p>';
 			buf += '<p><label class="checkbox"><input type="checkbox" name="private" ' + (Storage.prefs('disallowspectators') ? 'checked' : '') + ' /> <abbr title="You can still invite spectators by giving them the URL or using the /invite command">Don\'t allow spectators</abbr></label></p>';
-			var bestOfDefault = format ? BattleFormats[format].bestOfDefault : false;
+			var bestOfDefault = format && BattleFormats[format] ? BattleFormats[format].bestOfDefault : false;
 			buf += '<p' + (!bestOfDefault ? ' class="hidden">' : '>');
 			buf += '<label class="checkbox"><input type="checkbox" name="bestof" /> <abbr title="Start a team-locked best-of-n series">Best-of-<input name="bestofvalue" type="number" min="3" max="9" step="2" value="3" style="width: 28px; vertical-align: initial;"></abbr></label></p>';
 			buf += '<p class="buttonbar"><button name="makeChallenge"><strong>Challenge</strong></button> <button type="button" name="dismissChallenge">Cancel</button></p></form>';
@@ -1386,7 +1386,7 @@
 				var $bestOfValueInput = this.sourceEl.closest('form').find('input[name=bestofvalue]');
 				if ($bestOfCheckbox && $bestOfValueInput) {
 					var $parentTag = $bestOfCheckbox.parent().parent();
-					var bestOfDefault = BattleFormats[format].bestOfDefault;
+					var bestOfDefault = BattleFormats[format] && BattleFormats[format].bestOfDefault;
 					if (bestOfDefault) {
 						$parentTag.removeClass('hidden');
 						$bestOfValueInput.val(3);