Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading teams from server, add button to upload teams #2157

Merged
merged 8 commits into from
Oct 2, 2023

Conversation

mia-pi-git
Copy link
Member

Client-side integration for the teams database.
This PR:

  • Adds a button to upload a team next to the pokepaste button.
  • Supports pulling teams from the external DB via the loginserver. This is split into two levels: on startup, the client requests a list of teams from the loginserver, which responds with a list of teamIDs, mon IDs from that team, format, and team name. This leaves out the majority of the data. When the user opens the team in teambuilder, or tries to do anything with it, the app loads it from loginserver, caches it, then uses it.

I dislike having to add a callback parameter to sendTeam, but unfortunately we do not support async/await at the moment. Will take suggestions to improve that though.

@mia-pi-git mia-pi-git merged commit 5cf6cfd into smogon:master Oct 2, 2023
1 check passed
MathyFurret pushed a commit to MathyFurret/pokemon-showdown-client that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant