Bo3: Add challenge checkbox for VGC formats #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathyFurret
pushed a commit
to MathyFurret/pokemon-showdown-client
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a best-of-three checkbox to VGC formats (note: depending on how this is received, we may want to generalize with a property server-side on the format itself so other formats can also use it). When this box is checked, it adds Best of = 3 to custom rules sent to the challenge partner. The challenged recipient cannot select to make the format bo3.
Unlike privacy, I don't want to store the current state of bo3 being checked, because I can imagine lots of cases where you'd want to regularly switch back and forth. I recommend whenever we add a bo3 ladder that we make
challengeShow: falsefor that format.Credit @Karthik99999 for helping to parallel program this change.