Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make popups scrollable internally instead of adding scrollbar to body #2166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lorumic
Copy link

@lorumic lorumic commented Oct 20, 2023

  • Changed some CSS so that popups with an overflowing content can be scrollable internally, instead of adding a scrollbar to the body, so that the layout of the page is kept and does not seem broken.
  • Browser compatibility is not altered by the changes in this PR.

Before:

Peek 2023-10-20 09-26

After:

Peek 2023-10-20 09-27

@Zarel
Copy link
Member

Zarel commented Nov 20, 2023

I don't particularly like internal scrollbars for popups. I guess the current system is a little ugly, but I'm happy with how convenient/usable it is.

(It was also necessary on mobile back when internal scrolling was unnecessarily difficult on mobile.)

I guess one compromise would be to put it in an overlay and have the overlay be scrollable. You'd have to darken the overlay but that might not be a bad idea for Options.

@lorumic
Copy link
Author

lorumic commented Nov 21, 2023

I guess one compromise would be to put it in an overlay and have the overlay be scrollable. You'd have to darken the overlay but that might not be a bad idea for Options.

Thanks for the feedback @Zarel. Just to check that I understood correctly, you mean using, for this popup, the same approach that is used for the avatar selection, right?

Peek 2023-11-21 21-45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants