Design refresh #2175
Merged
Design refresh #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- client.css no longer duplicates a bunch of battle-log.css - topbar CSS is simplified a lot
(Also add active states to notifying buttons)
|
I've deleted 350 lines from client.css but there are still 3300 left... Oh well, the remaining CSS should be a lot less jank. |
|
After some consideration, I'm going with this as the in-sim replay layout: 
Least pretty of the layouts I was considering, but probably the most usable. |
|
For posterity, here's all the layouts I considered:
The fifth isn't very pretty, but it's very usable so that's the one I went with in the end. |
|
Very good dark mode improvements |
MathyFurret
pushed a commit
to MathyFurret/pokemon-showdown-client
that referenced
this pull request
Mar 25, 2024
Mostly this makes dark mode darker, but it does come with a whole suite of other design improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Felucia mentioned she had some custom CSS in dark mode to make it darker, so I figured I'd try my hand at a design refresh to make it not quite so bright. In the process, I've made the buttons look more 3D, matching light mode. Sorry, any dark mode users who prefer flat design.
This also updates all remaining OS-style buttons into PS-style buttons, so they'll be properly dark-mode.
This refresh focuses on dark mode, but light mode gets some improvements as well.
(top: old, bottom: new)
(left: old, right: new)
(left: old, right: new)
(left: old, right: new)
(left: old, right: new)
(left: old, right: new)
(left: old, right: new)
(left: old, right: new)