CSS : Minor fix #2177
CSS : Minor fix #2177
Conversation
Distrib-ps
commented
Nov 4, 2023
Distrib-ps
commented
old
new
old
new
old
new
old
new
Co-authored-by: pyuk-bot <[email protected]>
The same issues happens in the 'Could not connect to server' popup where 'Work offline' has the browser button style. So probably just fix it in this PR too. |
| @@ -247,7 +247,6 @@ i.subtle:hover { | |||
| position: relative; | |||
| padding: 3px 2px 3px 2px; | |||
| margin: 0 -1px 0 0; | |||
| top: 1px; | |||
There was a problem hiding this comment.
I thought the spacing was intentional
There was a problem hiding this comment.
Sorry, I'm still confused. What is this changing and why? Do you have before/after screenshots?
There was a problem hiding this comment.
Yeah,
It's the little gap at the top
But when I think about it, maybe it was on purpose
| @@ -163,6 +163,9 @@ button:disabled { | |||
| text-shadow: none; | |||
| color: #F9F9F9; | |||
| } | |||
| .dark select.button { | |||
| background-color: #2b2c31 !important; | |||
There was a problem hiding this comment.
I have a guess as to what's going on here but what browser is this bad???
There was a problem hiding this comment.
Hah, it turns out that Chrome for Windows has this problem, but Chrome for Mac doesn't.
Anyway, interesting solution, but it turns out styling option works, and doesn't require your hack that makes select buttons uglier.
| @@ -1202,12 +1202,12 @@ | |||
| } | |||
| for (i = 0; i < this.curSetList.length; i++) { | |||
| if (this.curSetList.length < this.curTeam.capacity && this.deletedSet && i === this.deletedSetLoc) { | |||
| buf += '<li><button name="undeleteSet"><i class="fa fa-undo"></i> Undo Delete</button></li>'; | |||
| buf += '<li><button name="undeleteSet" class="button"><i class="fa fa-undo"></i> Undo Delete</button></li>'; | |||
There was a problem hiding this comment.
This looks better as not a button...
There was a problem hiding this comment.
Would you prefer to keep it white?
There was a problem hiding this comment.
It shouldn't be white. I must be mixing this up with something else.
There was a problem hiding this comment.
Yeah, I got this mixed up with undeleting teams, which already has styling.
- Updates New Replays for the design refresh - Updates STYLING.html for the design refresh Fixes smogon#2177
