Speed up Random Battles species selection #10138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkerab
reviewed
Jan 27, 2024
Thanks, you're right. This simplifies the code. I will make the other necessary adjustments Co-authored-by: urkerab <[email protected]>
MathyFurret
pushed a commit
to MathyFurret/pokemon-showdown
that referenced
this pull request
May 21, 2024
* Speed up Random Battles species selection * Apply suggestions from code review Thanks, you're right. This simplifies the code. I will make the other necessary adjustments Co-authored-by: urkerab <[email protected]> * Improve gen 9 weight code * Apply the same changes to old gens * Go back to baseSpeciesPool * unintended newlines * missed one * Removing the final newline --------- Co-authored-by: urkerab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors species selection in Random Battles to be more efficient.
Previously, after selecting a base species, it goes through the entire array of species to record the ones with the corresponding base species, then chooses one of them randomly.
Now,
getPokemonPool()outputs an objectpokemonPoolwhich records, for each base species, the list of species with that base species. Instead of checking every species, it now just samples from the list corresponding to the base species.This approach is significantly faster and keeps the appearance rates standardization from #9708.
My local testing shows that this speeds up overall team generation by around 20% for Gen 9 Random Battle and 50% for Gen 7 Random Battle.