Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ogerpon and Terapagos can't transform #10820

Closed
wants to merge 5 commits into from

Conversation

@urkerab
Copy link
Contributor

urkerab commented Jan 12, 2025

Did you delete those existing tests by mistake?

@andrebastosdias
Copy link
Contributor Author

andrebastosdias commented Jan 12, 2025

Oh, I didn’t notice the Espeon battle because it was the same test. Thanks!

As for the Terapagos one, it wasn't a mistake. Terapagos can’t use Transform, so the test wouldn’t pass. I can’t think of a situation where pokemon.baseSpecies would be Terapagos-Terastal, but pokemon.species wasn’t. I mean, there is one: when it Terastalizes, but it loses the ability, so that wouldn’t apply.

Edit: the test in terapagos.js would never happen either.

@Lusamine
Copy link
Contributor

I believe the test you referenced needs to be redone because it's vs wild Pokemon, where Transform fails due to the Smeargle cloning exploit patch. Terapagos is able to Transform in an NPC battle.

@andrebastosdias andrebastosdias marked this pull request as draft January 12, 2025 09:14
@andrebastosdias
Copy link
Contributor Author

andrebastosdias commented Jan 13, 2025

@andrebastosdias andrebastosdias deleted the transform branch January 13, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants