PRNG: Remove 'TODO: benchmark' comment #10822
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alternative big-endian read impl is indeed slower.
|
I actually made a pr to speed up the method used in this pr. Check #10818 |
|
With that change, the commented-out code is still slightly slower. The 4x number was just for comparing those single lines; the big-endian read is a small fraction of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alternative big-endian read impl is indeed slower. (if you're curious, in a loop it was about 4x slower).
Also, PRNG code currently accounts for very, very little of the execution time for a battle.