PRNGSeed is now a string #10826
Merged
PRNGSeed is now a string #10826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so we no longer need to ad-hoc convert seeds from strings to arrays when we get them from text protocols like the command line or BattleStream's `reseed` command. It also has the side benefit of making inputlogs very slightly smaller.
KrisXV
reviewed
Jan 15, 2025
| return seed.join(',') as PRNGSeed; | ||
| } | ||
| static get(prng?: PRNG | PRNGSeed | null) { | ||
| return prng && typeof prng !== 'string' && !Array.isArray(prng) ? prng : new PRNG(prng as PRNGSeed); |
There was a problem hiding this comment.
is the typecast necessary here? doesn't it default to PRNGSeed | null after the first check is done?
There was a problem hiding this comment.
The Array.isArray part confuses it. Reasonable because arrays are not PRNGSeeds anymore, but annoying for us and requires a cast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so we no longer need to ad-hoc convert seeds from strings to arrays when we get them from text protocols like the command line or BattleStream's
reseedcommand.It also has the side benefit of making inputlogs very slightly smaller.