Skip to content

Update criterion requirement from 0.4 to 0.6 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ windows-sys = { version = "0.60.0", features = ["Win32_Foundation"] }
async-channel = "2.0.0"
async-net = "2.0.0"
blocking = "1"
criterion = { version = "0.4", default-features = false, features = ["cargo_bench_support"] }
criterion = { version = "0.6", default-features = false, features = ["cargo_bench_support"] }
getrandom = "0.3"
signal-hook = "0.3"
tempfile = "3"
Expand Down
5 changes: 4 additions & 1 deletion benches/io.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
//! Benchmarks for a variety of I/O operations.

#![allow(clippy::incompatible_msrv)] // false positive: https://github.com/rust-lang/rust-clippy/issues/12257#issuecomment-2093667187

use async_io::Async;
use criterion::{black_box, criterion_group, criterion_main, Criterion};
use criterion::{criterion_group, criterion_main, Criterion};
use futures_lite::{future, prelude::*};
use std::hint::black_box;
use std::net::{Ipv4Addr, SocketAddr, TcpListener, TcpStream, UdpSocket};

/// Block on a future, either using the I/O driver or simple parking.
Expand Down
5 changes: 4 additions & 1 deletion benches/timer.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
//! Benchmarks for registering timers.

#![allow(clippy::incompatible_msrv)] // false positive: https://github.com/rust-lang/rust-clippy/issues/12257#issuecomment-2093667187

use async_io::Timer;
use criterion::{black_box, criterion_group, criterion_main, Criterion};
use criterion::{criterion_group, criterion_main, Criterion};
use futures_lite::future;
use std::hint::black_box;
use std::time::Duration;

/// Create a new `Timer` and poll it once to register it into the timer wheel.
Expand Down
Loading