Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode URL fragments #8

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Encode URL fragments #8

merged 3 commits into from
Sep 28, 2023

Conversation

ad-chaos
Copy link
Contributor

@ad-chaos ad-chaos commented Feb 4, 2023

This fixes the browser not scrolling to the exact tag when doing :h :terminal for example.

This fixes the browser not scrolling to the exact tag when doing
`:h :terminal` for example.
Copy link
Owner

@smolck smolck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only thing is maybe throw in a test case with all the stuff that shouldn’t be encoded (the alphabet and numbers) and assert nothing changes after encoding it

@ad-chaos ad-chaos requested a review from smolck September 28, 2023 04:26
(though I do appreciate the sentiment :P)
Copy link
Owner

@smolck smolck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smolck smolck merged commit f190aba into smolck:main Sep 28, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants