Phoenix 1.4 Upgrade #397
Open
Phoenix 1.4 Upgrade #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spinlock99
commented
Nov 15, 2018
| @@ -304,6 +304,10 @@ defmodule Mix.Tasks.Coh.Clean do | |||
|
|
|||
| defp remove!(config, _), do: config | |||
|
|
|||
| defp migrations_path(repo) do | |||
| "priv/repo/migrations/" | |||
| end | |||
There was a problem hiding this comment.
There were errors running mix test re: migrations_path/1 being undefined. So, I added these embarrassing hacks to see if the tests would pass :)
The tests do pass now but it seems like there should be a better solution for migrations_path/1 being undefined.
spinlock99
commented
Nov 15, 2018
| @@ -666,6 +666,8 @@ defmodule Mix.Tasks.Coh.Install do | |||
|
|
|||
| defp gen_trackable_migration(config), do: config | |||
|
|
|||
| defp migrations_path(repo), do: "priv/repo/migrations/" | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This is a work in progress and is working well so far. The big issue is that
Routesis not defined in the Coherence templates. I'd appreciate any help on getting this PR into good shape.Done:
To Do:
Routesis not available in the Coherence templates. Need to figure out why to use path helpers rather than strings (e.g.sessions_path/2vs. "/sessions").