Refactor AREDN sysinfo.json parsing #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smsearcy
commented
Jul 5, 2024
smsearcy
commented
Jul 5, 2024
smsearcy
force-pushed
the
104-refactor-sysinfo-parsing
branch
from
074ac9b
to
4cd5877
Compare
smsearcy
force-pushed
the
104-refactor-sysinfo-parsing
branch
from
4cd5877
to
fbed52d
Compare
Default to "modern" parsing, falling back to legacy on errors. Update AREDN data classes to use new `attrs` syntax, with some refactoring. Stop parsing `services_local` JSON because it wasn't being used.
smsearcy
force-pushed
the
104-refactor-sysinfo-parsing
branch
from
fbed52d
to
57860c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate parsing of legacy API so there are fewer branches and checks in the parsing code.
Closes #104