Default to UTC #68
Closed
Default to UTC #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use UTC as the default timezone instead of the server's timezone. Rename the filter to `client_tz` instead of `local_tz` to more accurately reflect it's purpose (once I add the UI for users to customize their timezone).
Update `request.timezone` to be timezone object (so Pendulum doesn't need to convert string back to object when rendering). Wrap RRDtool graph calls in changes to the `TZ` environment variable so they render in the preferred timezone. Update graph views to pass timezone to the graph rendering functions. Fix bug in the fallback for loading timezone from cookie.
|
I'm not going to default to UTC until I have preferences in place (#91). That might end up replacing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use UTC for all times, instead of server's timezone.
(Code is in place to facilitate users choosing their preferred timezone, but the UI for that is not included in this branch.)
Closes #64