Trapping rain water problem using c++(Optimised)

[vishvarana]

Have you read the Contributing Guidelines on Pull Requests?

Yes

Description

The problem is what most amount of rain water can the container store with different heights of the walls given as an array.

Checklist

• I've read the contribution guidelines.
• I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests

#278

Fill up the DCP form

If you are a part of DCP 21, fill up this form after the PR is merged.

The links provided in the form will be checked thoroughly, if someone tries fooling around, strict actions will be taken against the individual.

[sumitvajarinkar]

@vishvarana
I run this solution but I am getting the wrong answer. Can you please check it?
The correct answer for input n=9, 1,8,6,2,5,4,8,3,7 is 19 and this code answer is 49.

[vishvarana]

The maximum heights chosen will be 8 and 7 that is 2nd and last element of the array.
The base will be 8-1=7(index of last element - 2nd element)
Water can only be filled upto the shorter of the two heights or it will overflow
Hence the area will be 7x7(shorter height*base)=49

[vishvarana]

The idea is to maximize the area to trap water by both heights as well as base length.

[vishvarana]

Smallest distinct window problem using c++
#317 issue

[vishvarana]

Please review

[Saviour1001]

@vishvarana add comments and explain the question in the code. Also add complexities.

[vishvarana]

Trapping the rain water - I have explained the problem in previous comments
Time complexity - O(n)
Space complexity - O(1)

Smallest distinct window in a string containing all other characters of the string :
The problem focuses on 2 strings, one is the main, other being a part or substring. The idea is to find all the characters present in the part string in the main string and to print those contents of the string, which has this found characters
Time complexity - O(n^2)
Space complexity - O(1)

[vishvarana]

There are 2 solutions added and both explained with complexities.

[Saviour1001]

@vishvarana I am asking you to add the description and complexities as comments in the code file.

[smv1999]

@vishvarana, Also place the file in appropriate folder.

[vishvarana]

Required changes made.
Please review and let me know for any other improvements

[smv1999]

Smallest distinct window problem using c++
#317 issue

Raise a new PR for #317

[vishvarana]

New PR made
#651

[smv1999]

Then delete smallestdistinctwindow.cpp in this PR as it is not related to this. Also, delete the unnecessary (repetitive) files (which are not placed in any folder).

[vishvarana]

Required changes done

[smv1999]

Great. Just add some comments to explain your core logic.

[vishvarana]

Added comments in the cpp file

[Saviour1001]

Good work @vishvarana