fix: add --parsable to sbatch call for a more robust output parsing #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeesters
approved these changes
Aug 6, 2024
|
Thank you for your contribution! I will merge this (after fixing the linter issue) - but a new release has to wait until some more contribs are merged. This contrib does not change behaviour, after all. It may wait a day or two. |
|
Sorry for the linter issue, I fixed it. Of course the current implementation works fine so it can wait for the next release :) . Thank you for time! |
|
no need to apologize - thank you for your contribution once more! (now, after the holidays, I am still pretty busy, but will work on improving the code once more) |
This was referenced Aug 8, 2024
cmeesters
pushed a commit
that referenced
this pull request
Aug 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.10.0](v0.9.0...v0.10.0) (2024-08-23) ### Features * in job stability ([#137](#137)) ([c27f5f8](c27f5f8)) ### Bug Fixes * add --parsable to sbatch call for a more robust output parsing ([#125](#125)) ([5e41d05](5e41d05)) * issue [#109](#109) - preemption is no longer considered a failed status ([#132](#132)) ([6dad273](6dad273)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced the `--parsable` option to the `sbatch` command for improved output parsing. - **Bug Fixes** - Revised job preemption handling to prevent it from being marked as a failed status, enhancing job stability. - **Chores** - Updated the version number of the Snakemake Executor Plugin for Slurm to 0.10.0 in preparation for the release. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in #121 (comment) , this implementation seems more robust than match a word with only numbers (which could break in future versions of slurm, or if a cluster name is made of only numbers).