fix: null byte account guess #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no odd parsing occured
…no trailing line feed is present
|
The issuer reported in #76 that this fix appears to be working. |
|
waited too long |
cmeesters
pushed a commit
that referenced
this pull request
Jun 25, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.0](v0.6.0...v0.7.0) (2024-06-25) ### Features * warning if run in job ([#78](#78)) ([257e830](257e830)) ### Bug Fixes * null byte account guess ([#81](#81)) ([92d4445](92d4445)) ### Documentation * added mini paragraph about Conda and Env Modules ([#42](#42)) ([c821b5e](c821b5e)) * added paragraphs about dynamic resource allocation ([#79](#79)) ([06a1555](06a1555)) * storage update ([#80](#80)) ([7e19560](7e19560)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cmeesters
added a commit
that referenced
this pull request
Jul 5, 2024
attempt to ensure that a '(null)' byte does not overthrow the account testing.
cmeesters
pushed a commit
that referenced
this pull request
Jul 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.0](v0.6.0...v0.7.0) (2024-06-25) ### Features * warning if run in job ([#78](#78)) ([257e830](257e830)) ### Bug Fixes * null byte account guess ([#81](#81)) ([92d4445](92d4445)) ### Documentation * added mini paragraph about Conda and Env Modules ([#42](#42)) ([c821b5e](c821b5e)) * added paragraphs about dynamic resource allocation ([#79](#79)) ([06a1555](06a1555)) * storage update ([#80](#80)) ([7e19560](7e19560)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cmeesters
added a commit
that referenced
this pull request
Jul 12, 2024
attempt to ensure that a '(null)' byte does not overthrow the account testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to ensure that a '(null)' byte does not overthrow the account testing.