-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GATK ValidateVariants #390
base: master
Are you sure you want to change the base?
Conversation
log: | ||
"results/sample_VALID.log", | ||
params: | ||
R="genome.fasta", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot find this to be used in the wrapper. On the other hand, extra is missing. Maybe you meant to write
R="genome.fasta", | |
extra="", # optional extra arguments |
input: | ||
vcf="sample.vcf", | ||
output: | ||
"results/sample_VALID.vcf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the output should just have a .txt suffix or so, since this tool will not create a vcf file, right?
Maybe it would also be nice to set |
This PR was marked as stale because it has been open for 6 months with no activity. |
Description
An implementation of the GATK ValidateVariants tool
QC
For all wrappers added by this PR, I made sure that
input:
andoutput:
file paths in the resulting rule can be changed arbitrarily,map_reads
for a step that maps reads),environment.yaml
specifications follow the respective best practices,input:
oroutput:
),Snakefile
s and their entries are explained via comments (input:
/output:
/params:
etc.),stderr
and/orstdout
are logged correctly (log:
), depending on the wrapped tool,tempfile.gettempdir()
points to (see here; this also means that using any Pythontempfile
default behavior works),meta.yaml
contains a link to the documentation of the respective tool or command,Snakefile
s pass the linting (snakemake --lint
),Snakefile
s are formatted with snakefmt,