Fix preview branch build and enable automation
#255
Conversation
|
Oh I didn't realise the build was broken, I'll take a look at that soon. The other option is to merge these relatively trivial changes, and we can address the build issues in another PR? |
|
I'd like you to fix the build first, either in this PR or in a separate one, so we can immediately test everything after merging. |
This change ensures that the same version of the compiler is used when compiling libav and libaom such that we avoid lto version mismatches.
jnsgruk
changed the title
preview branchpreview branch build and enable automation
Original commit message: - Add some extra layout definitions for gimp to find some platform executables and shared files - Update the environment: block for runtime search paths that are missing in the platform snap's desktop-launch script - Add missing libva-drm and libva-x11 libraries - Ensure gimp is built as a relocatable executable so that it can find some of its assets easier in the snap - Move the debug symbols compiler flags to use the configure script's support - Add missing iso-codes because gimp refuses to look for them anywhere but $SNAP/usr/share/xml/iso-codes - Add missing lua-lgi for gimp's lua scripting capability - Fix the cleanup part to not delete the iso-codes we're including in the snap directly
|
Latest commit grabs the changes from #202 and integrates them here. |
|
This last commit builds fine on my box. I also noticed that gmic is missing here - I'm 95% through porting that for core22 / gimp 2.99 but not quite finished - will leave on a separate branch unless I finish before this merges :) |
|
@merlijn-sebrechts this is now actually "working", but the job takes too long and is killed by Github Actions (we can't make it timeout after a longer time without paying). Are you happy to merge this? I'll need to have a think about what we can do for the PR flow in the case that the build takes ages! What I can't work out is why the build on |
|
Latest commit tested with
|
|
This is now good to go from my side -- both architectures build fine on Launchpad as of today! |
|
@merlijn-sebrechts success! We have a green CI run for the pull request flow! (see here). I've removed the commit that enabled it to trigger, because I had to loosen the branch constraint on the pull request flow, but I think I can fix that in a later request when we try to converge the two branches? |
This PR adds new automation to the
previewbranch. It depends on snapcrafters/ci#28, and should not be merged before that PR.These files are very similar to those on the
candidatebranch, but specify a different channel.@merlijn-sebrechts before this can be merged, we need to create an environment named "Preview Candidate Branch" which has all the necessary secrets in it, noting the name of
${{ secrets.SNAP_STORE_PREVIEW_STABLE }}.Let me know what you think!
Edit*: This grew arms and legs - it turns out the preview build was actually quite broken, and took some significant wrangling to get it to build and launch on Ubuntu. I've tried to break down into small commits where possible, but let me know if there is any further context required!
Closes #244
Fixes #126
Fixes #219