Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Release update and screenshot gathering automation #41

Merged
merged 17 commits into from
Dec 4, 2023
Merged

CI: Release update and screenshot gathering automation #41

merged 17 commits into from
Dec 4, 2023

Conversation

kz6fittycent
Copy link
Contributor

@kz6fittycent kz6fittycent commented Nov 30, 2023

  • Modified script for getting latest release from GH API
  • Minor cleanup of some old comments in yml files
  • Update snapraft.yaml to version instead of adopt-info

I searched for anything that may be lacking, but let me know if/what I missed.

just in case!
added cleanup
Testing
Copied with minor mods from Discord snap
- snap promote candidate and stable
- sync version w/ upstream (not sure about this one)
Restored to original from Discord
Cleanup of test-snap-can-build.yaml
CI: add release update and screenshot gathering automation
adopt-info -> version
Copy link
Member

@merlijn-sebrechts merlijn-sebrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some of these actions are still using the old in-repo ones. Can you take a look at https://github.com/snapcrafters/signal-desktop/tree/candidate/.github/workflows and update accordingly?

I apologize for this churn. The current ones in signal-desktop should be the final ones, I promise!

@kz6fittycent
Copy link
Contributor Author

I see some of these actions are still using the old in-repo ones. Can you take a look at https://github.com/snapcrafters/signal-desktop/tree/candidate/.github/workflows and update accordingly?

I apologize for this churn. The current ones in signal-desktop should be the final ones, I promise!

No problem! I was fully expecting to redo something because of my own errors anyway. Give me a couple of days to get to it.

- Updated/renamed
  - update-to-stable
  - pull-request
  - release-to-candidate
  - sync-version-with-upstream
Removed:
  - Removed test-snap-can-build
Needed to change some of the script to allow the double-quotes to remain around the version for the snap.
Copy link
Member

@merlijn-sebrechts merlijn-sebrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change. Otherwise, it looks good!

.github/vmctl Outdated
@@ -0,0 +1,113 @@
#!/usr/bin/env bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this entire file. The new workflow downloads the latest version automatically

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stand by

@merlijn-sebrechts
Copy link
Member

I've added the tokens, so this should work as soon as we merge it!

Copy link
Member

@merlijn-sebrechts merlijn-sebrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guddd!

@merlijn-sebrechts merlijn-sebrechts merged commit d2c564b into snapcrafters:candidate Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants