-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Release update and screenshot gathering automation #41
CI: Release update and screenshot gathering automation #41
Conversation
just in case!
added cleanup
Copied with minor mods from Discord snap - snap promote candidate and stable - sync version w/ upstream (not sure about this one)
Restored to original from Discord Cleanup of test-snap-can-build.yaml
CI: add release update and screenshot gathering automation
adopt-info -> version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some of these actions are still using the old in-repo ones. Can you take a look at https://github.com/snapcrafters/signal-desktop/tree/candidate/.github/workflows and update accordingly?
I apologize for this churn. The current ones in signal-desktop should be the final ones, I promise!
No problem! I was fully expecting to redo something because of my own errors anyway. Give me a couple of days to get to it. |
- Updated/renamed - update-to-stable - pull-request - release-to-candidate - sync-version-with-upstream Removed: - Removed test-snap-can-build
Needed to change some of the script to allow the double-quotes to remain around the version for the snap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small change. Otherwise, it looks good!
.github/vmctl
Outdated
@@ -0,0 +1,113 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this entire file. The new workflow downloads the latest version automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stand by
I've added the tokens, so this should work as soon as we merge it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guddd!
version
instead ofadopt-info
I searched for anything that may be lacking, but let me know if/what I missed.