Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LTS Track for Jenkins Snap #88

Merged
merged 6 commits into from
Jul 18, 2024
Merged

LTS Track for Jenkins Snap #88

merged 6 commits into from
Jul 18, 2024

Conversation

kz6fittycent
Copy link
Contributor

In response to #81

@kz6fittycent kz6fittycent changed the title Lts LTS Track for Jenkins Snap May 13, 2024
jnsgruk
jnsgruk reviewed May 23, 2024
View reviewed changes
Copy link
Member

@jnsgruk jnsgruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little unclear on the intention here -- are you looking to replace the candidate track with an lts track, or run both at the same time?

.github/workflows/release-to-candidate.yml Outdated Show resolved Hide resolved
@kz6fittycent
Update release-to-candidate.yml
0baf1c5 
changed to `snapcrafters/ci/release-to-candidate@main`
@jnsgruk
Copy link
Member

jnsgruk commented Jun 1, 2024

A few more comments now I understand better - thank you! :)

@kz6fittycent
PR 88
4d9b2a5 
Addressing items called out by @jnsgruk
jnsgruk
jnsgruk requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@jnsgruk jnsgruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just a couple of minor tweaks. Thank you for the iteration!

.github/workflows/sync-version-with-upstream.yml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
kz6fittycent added a commit to kz6fittycent/jenkins that referenced this pull request Jul 18, 2024
@kz6fittycent
Update sync-version-with-upstream.yml
20584aa 
See: snapcrafters#88 (comment)
@kz6fittycent kz6fittycent mentioned this pull request Jul 18, 2024
Merged
@jnsgruk jnsgruk merged commit ff6e113 into snapcrafters:lts Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnsgruk jnsgruk jnsgruk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kz6fittycent @jnsgruk