-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump core20 to core24 #16
Conversation
Hi @abitrolly - this one needs a bit more love. There are a few more updates required for this transition, which you can read more about here: https://snapcraft.io/docs/migrate-core24 |
@jnsgruk done. Why releases are not promoted to Is it possible to give it read/write access to |
Thanks for the iteration. Once this has been merged, I'll be able to promote it to Why does the app need access to |
@abitrolly if you're interested, you could look at porting the GitHub Workflows from one of our other snaps (discord, signal-desktop) which would add better release automation 😄 |
Because the primary use case for |
@jnsgruk I know all that automation (unfortunately), and the process of copy-pasting this block https://github.com/snapcore/action-publish?tab=readme-ov-file#snapcraft-publish-action into https://github.com/snapcrafters/magic-wormhole/blob/master/.github/workflows/test-snap-can-build.yml should be done by admins who have to configure credentials. |
I failed to see how it could not be done in a regular directory accessible by snaps, as I don't rely on the /tmp directory's volatile characteristics to store such files. Regardlessly, it's an architectural (and security) limitation that snap apps don't have access to the /tmp directory so the use case won't be supported.
Anyone can make the code change, it's just that the credentials need to be set by others. |
Indeed, if someone makes the code changes, I'll review and make sure the credentials are in place 🙂 |
If you change the behavior of original project, the good practice is to add a patch that explains users how to fix the problem, because instead they are left with hardly readable The whole experience with snaps is frustrating. |
You have a good point, I've filed #19 for the possibility to improve in that regard. |
No description provided.