Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump core20 to core24 #16

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Bump core20 to core24 #16

merged 3 commits into from
Oct 8, 2024

Conversation

abitrolly
Copy link
Contributor

No description provided.

@jnsgruk
Copy link
Member

jnsgruk commented Oct 7, 2024

Hi @abitrolly - this one needs a bit more love. There are a few more updates required for this transition, which you can read more about here: https://snapcraft.io/docs/migrate-core24

@abitrolly
Copy link
Contributor Author

@jnsgruk done.

Why releases are not promoted to stable? https://forum.snapcraft.io/t/why-releases-are-not-promoted-to-stable/43307

Is it possible to give it read/write access to /tmp?

@jnsgruk
Copy link
Member

jnsgruk commented Oct 8, 2024

Thanks for the iteration.

Once this has been merged, I'll be able to promote it to stable.

Why does the app need access to /tmp? It already has access to the user's home directory, and to removable media.

@jnsgruk
Copy link
Member

jnsgruk commented Oct 8, 2024

@abitrolly if you're interested, you could look at porting the GitHub Workflows from one of our other snaps (discord, signal-desktop) which would add better release automation 😄

@jnsgruk jnsgruk merged commit 3394beb into snapcrafters:master Oct 8, 2024
1 check passed
@abitrolly
Copy link
Contributor Author

Why does the app need access to /tmp? It already has access to the user's home directory, and to removable media.

Because the primary use case for wormhole is to send discardable files that need to be processed and sent further on another PC. Like errors from this snap that I paste to wormhole tracker. Home dirs are usually persistent and their synchronization is better handled by syncthing and the likes.

@abitrolly abitrolly deleted the patch-1 branch October 8, 2024 07:25
@abitrolly
Copy link
Contributor Author

@abitrolly if you're interested, you could look at porting the GitHub Workflows from one of our other snaps (discord, signal-desktop) which would add better release automation 😄

@jnsgruk I know all that automation (unfortunately), and the process of copy-pasting this block https://github.com/snapcore/action-publish?tab=readme-ov-file#snapcraft-publish-action into https://github.com/snapcrafters/magic-wormhole/blob/master/.github/workflows/test-snap-can-build.yml should be done by admins who have to configure credentials.

@brlin-tw
Copy link
Contributor

brlin-tw commented Oct 8, 2024

@abitrolly

Because the primary use case for wormhole is to send discardable files that need to be processed and sent further on another PC.

I failed to see how it could not be done in a regular directory accessible by snaps, as I don't rely on the /tmp directory's volatile characteristics to store such files.

Regardlessly, it's an architectural (and security) limitation that snap apps don't have access to the /tmp directory so the use case won't be supported.

the process of copy-pasting this block https://github.com/snapcore/action-publish?tab=readme-ov-file#snapcraft-publish-action into https://github.com/snapcrafters/magic-wormhole/blob/master/.github/workflows/test-snap-can-build.yml should be done by admins who have to configure credentials.

Anyone can make the code change, it's just that the credentials need to be set by others.

@jnsgruk
Copy link
Member

jnsgruk commented Oct 8, 2024

Anyone can make the code change, it's just that the credentials need to be set by others.

Indeed, if someone makes the code changes, I'll review and make sure the credentials are in place 🙂

@abitrolly
Copy link
Contributor Author

Regardlessly, it's an architectural (and security) limitation that snap apps don't have access to the /tmp directory so the use case won't be supported.

If you change the behavior of original project, the good practice is to add a patch that explains users how to fix the problem, because instead they are left with hardly readable wormhole innards on the screen.

The whole experience with snaps is frustrating.

@brlin-tw
Copy link
Contributor

brlin-tw commented Oct 8, 2024

@abitrolly

If you change the behavior of the original project, the good practice is to add a patch that explains to users how to fix the problem

You have a good point, I've filed #19 for the possibility to improve in that regard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants