Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use latest snapcrafters actions #81

Merged
merged 3 commits into from
Nov 14, 2023
Merged

ci: use latest snapcrafters actions #81

merged 3 commits into from
Nov 14, 2023

Conversation

jnsgruk
Copy link
Member

@jnsgruk jnsgruk commented Nov 14, 2023

Opened in favour of #70. Brings over the latest actions as per the signal-desktop snap.

Also configures dependabot to automatically bump Github Actions each month.

@jnsgruk
Copy link
Member Author

jnsgruk commented Nov 14, 2023

@merlijn-sebrechts only thing we don't yet have here are the candidate and stable branches, with candidate as the default. I don't have permissions for that :)

@merlijn-sebrechts
Copy link
Member

Great, thanks for your help @jnsgruk !

I renamed master to candidate. Will work on the secrets later today. I'll close the edge channel in the Snap Store once the first candidate release is out. That way, all users that track edge are migrated to candidate and will track our testing releases again. If I close the edge channel now, they will be migrated to the stable channel instead.

Just wanted to add some context: we don't use a stable branch, only a stable channel in the Snap Store. This is so that the exact bits we test in candidate will be what we promote to stable channel. There is no rebuild in-between.

If we ever want to track non-stable releases too, we can re-create an edge branch and an edge channel, but those builds should never be promoted to candidate or stable.

Copy link
Member

@merlijn-sebrechts merlijn-sebrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge it and see if it works!

curl -sL https://api.github.com/repos/mattermost/desktop/releases |
jq . | grep tag_name | grep -v beta | grep -v rc | head -n 1 | cut -d'"' -f4 | tr -d 'v'
)
sed -i 's/^\(version: \).*$/\1'"$VERSION"'/' snap/snapcraft.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to also do this with yq? Now that you've shown me the light, I want to avoid sed :)

@merlijn-sebrechts merlijn-sebrechts merged commit 9b53e49 into snapcrafters:candidate Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants