-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use latest snapcrafters actions #81
ci: use latest snapcrafters actions #81
Conversation
@merlijn-sebrechts only thing we don't yet have here are the |
Great, thanks for your help @jnsgruk ! I renamed Just wanted to add some context: we don't use a If we ever want to track non-stable releases too, we can re-create an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge it and see if it works!
curl -sL https://api.github.com/repos/mattermost/desktop/releases | | ||
jq . | grep tag_name | grep -v beta | grep -v rc | head -n 1 | cut -d'"' -f4 | tr -d 'v' | ||
) | ||
sed -i 's/^\(version: \).*$/\1'"$VERSION"'/' snap/snapcraft.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to also do this with yq
? Now that you've shown me the light, I want to avoid sed
:)
Opened in favour of #70. Brings over the latest actions as per the signal-desktop snap.
Also configures dependabot to automatically bump Github Actions each month.