Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow zlib-0.7, time-1.14, drop GHC 7 #333

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Allow zlib-0.7, time-1.14, drop GHC 7 #333

merged 2 commits into from
Apr 10, 2024

Conversation

andreasabel
Copy link
Contributor

@andreasabel andreasabel commented Apr 9, 2024 •
edited
Loading

  • Fix stack CI (nightly is now 9.8), bump action versions
  • Allow zlib-0.7, time-1.14, drop GHC 7, remove unused package old-locale

GHC 7 is not tested any longer, so we can as well require base >= 4.9 and drop a number of redundant conditionals.

Bumping zlib helps with:

@andreasabel andreasabel changed the title drop ghc 7 Allow zlib-0.7, time-1.14, drop GHC 7 Apr 9, 2024
@andreasabel
Copy link
Contributor Author

I published the relaxation of zlib and time as revision 4: https://hackage.haskell.org/package/snap-core-1.0.5.1/revisions/

@andreasabel
Copy link
Contributor Author

@cydparser PR is ready for review.

cydparser
cydparser approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@cydparser cydparser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cydparser cydparser merged commit 7182cf1 into snapframework:master Apr 10, 2024
10 checks passed
@andreasabel andreasabel deleted the drop-ghc-7 branch April 11, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydparser cydparser cydparser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreasabel @cydparser