Testsuite fixes #112
Open
Testsuite fixes #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mightybyte
reviewed
Mar 26, 2018
snap-server.cabal
Outdated
| @@ -244,7 +244,8 @@ Test-suite testsuite | |||
| parallel >= 3 && < 4, | |||
| test-framework >= 0.8.0.3 && < 0.9, | |||
| test-framework-hunit >= 0.2.7 && < 0.4, | |||
| test-framework-quickcheck2 >= 0.2.12.1 && < 0.4 | |||
| test-framework-quickcheck2 >= 0.2.12.1 && < 0.4, | |||
| Cabal | |||
There was a problem hiding this comment.
Why is this new dependency here? I don't see any code changes.
There was a problem hiding this comment.
IIRC https-streams complained about missing cabal lib. I've retested and the result of:
cabal sandbox init
cabal install --dependencies-only --enable-tests -fbuild-testserver -fopenssl
is this error message:
Configuring http-streams-0.8.5.5...
Failed to install http-streams-0.8.5.5
Build log ( /home/karel/git/snap-server/.cabal-sandbox/logs/http-streams-0.8.5.5.log ):
cabal: Error: some packages failed to install:
http-streams-0.8.5.5 failed during the configure step. The exception was:
user error (The package 'http-streams' requires Cabal library version -any &&
>=1.24 but no suitable version is installed.)
but well, indeed, adding Cabal there does not solve the issue. I've needed to perform separate
cabal install Cabal==2.0.1.1
to fix this and complete installation of dependencies. Then configure and cabal build run fine.
So I'll commit cleanup in a minute. Sorry for this and thanks for catching this.
mightybyte
reviewed
Apr 4, 2018
| @@ -516,7 +519,8 @@ Executable snap-test-server | |||
| time, | |||
| transformers, | |||
| unix-compat, | |||
| vector | |||
| vector, | |||
| filepath | |||
There was a problem hiding this comment.
Oops, here's another new dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.