Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS compatibility with newest versions of 'network' #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tom-audm
Copy link

@tom-audm tom-audm commented Jul 9, 2019

Fixes this error when installing from Hackage:

[19 of 20] Compiling Snap.Internal.Http.Server.TLS ( src/Snap/Internal/Http/Server/TLS.hs, dist/build/Snap/Internal/Http/Server/TLS.o )

src/Snap/Internal/Http/Server/TLS.hs:108:14: error:
    Not in scope: ‘Socket.bindSocket’
    Perhaps you meant one of these:
      ‘Socket.fdSocket’ (imported from Network.Socket),
      ‘Socket.mkSocket’ (imported from Network.Socket)
    Module ‘Network.Socket’ does not export ‘bindSocket’.
    |
108 |              Socket.bindSocket sock addr
    |              ^^^^^^^^^^^^^^^^^
cabal: Failed to build snap-server-1.1.1.1 (which is required by
exe:audm-backend from audm-backend-0.1.0.0). See the build log above for
details.

If you could push a release to Hackage with this fix that would be 👌

@tom-audm
Copy link
Author

The build failure here seems to be unrelated; it's trying to use cabal new-build with GHC 7.6.

@tom-audm
Copy link
Author

Can this be merged, @mightybyte or @gregorycollins ?

@jerith666
Copy link

I think this is superseded by #126 ... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants