Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use configmap instead of secret
Browse files Browse the repository at this point in the history
therealak12 committed Feb 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent eb69d08 commit 8158a80
Showing 8 changed files with 19 additions and 20 deletions.
7 changes: 7 additions & 0 deletions clients/harbor-client/charts/templates/configmap.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: {{ .Values.configMapName }}
namespace: {{ .Release.Namespace }}
data:
IMAGE_REFERENCE: "The image reference URL starts with //."
4 changes: 2 additions & 2 deletions clients/harbor-client/charts/templates/deployment.yaml
Original file line number Diff line number Diff line change
@@ -29,8 +29,8 @@ spec:
env:
- name: IMAGE_REFERENCE
valueFrom:
secretKeyRef:
name: {{ .Values.configSecretName }}
configMapKeyRef:
name: {{ .Values.configMapName }}
key: IMAGE_REFERENCE
resources:
{{- toYaml .Values.resources | nindent 12 }}
7 changes: 0 additions & 7 deletions clients/harbor-client/charts/templates/secret.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion clients/harbor-client/charts/values.yaml
Original file line number Diff line number Diff line change
@@ -30,4 +30,4 @@ autoscaling:
maxReplicas: 100
targetCPUUtilizationPercentage: 80

configSecretName: spcld-harbor-health-client
configMapName: spcld-harbor-health-client
6 changes: 6 additions & 0 deletions clients/proxy-client/charts/templates/configmap.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: {{ .Values.configMapName }}
data:
PROXY_URL: "The proxy address."
4 changes: 2 additions & 2 deletions clients/proxy-client/charts/templates/deployment.yaml
Original file line number Diff line number Diff line change
@@ -29,8 +29,8 @@ spec:
env:
- name: PROXY_URL
valueFrom:
secretKeyRef:
name: {{ .Values.configSecretName }}
configMapKeyRef:
name: {{ .Values.configMapName }}
key: PROXY_URL
resources:
{{- toYaml .Values.resources | nindent 12 }}
7 changes: 0 additions & 7 deletions clients/proxy-client/charts/templates/secret.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion clients/proxy-client/charts/values.yaml
Original file line number Diff line number Diff line change
@@ -30,4 +30,4 @@ autoscaling:
maxReplicas: 100
targetCPUUtilizationPercentage: 80

configSecretName: spcld-proxy-health-client
configMapName: spcld-proxy-health-client

0 comments on commit 8158a80

Please sign in to comment.