chore: instrument requests deduplicator (#657)

snapshot-labs · Aug 28, 2023 · f94fc10 · f94fc10
1 parent 22740dc
commit f94fc10
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/helpers/metrics.ts b/src/helpers/metrics.ts
@@ -109,3 +109,8 @@ new client.Gauge({
     });
   }
 });
+
+export const requestDeduplicatorSize = new client.Gauge({
+  name: 'request_deduplicator_size',
+  help: 'Total number of items in the deduplicator queue'
+});
diff --git a/src/helpers/requestDeduplicator.ts b/src/helpers/requestDeduplicator.ts
@@ -1,3 +1,4 @@
+import { requestDeduplicatorSize } from './metrics';
 import { sha256 } from './utils';
 
 const ongoingRequests = new Map();
@@ -7,15 +8,16 @@ export default async function serve(id, action, args) {
   if (!ongoingRequests.has(key)) {
     const requestPromise = action(...args)
       .then(result => {
-        ongoingRequests.delete(key);
         return result;
       })
       .catch(e => {
-        ongoingRequests.delete(key);
         throw e;
+      }).finally(() => {
+        ongoingRequests.delete(key);
       });
     ongoingRequests.set(key, requestPromise);
   }
 
+  requestDeduplicatorSize.set(ongoingRequests.size);
   return ongoingRequests.get(key);
 }