Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix lint task #617

Merged
merged 3 commits into from
Jul 27, 2023
Merged

chore: fix lint task #617

merged 3 commits into from
Jul 27, 2023

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jul 27, 2023

🧿 Current issues / What's wrong ?

The current "Test" task on CI is not running test, but lint
The lint task is running with --fix, so all errors will be ignored

💊 Fixes / Solution

Rename the task, and raise errors on lint task

🚧 Changes

  • Rename task from Test to Lint
  • the lint task should raise warnings on errors, so removing the --fix argument
  • Add a new typecheck task, to lint Typescript

🛠️ Tests

  • Run yarn lint
  • Run yarn typecheck

@wa0x6e wa0x6e requested a review from Todmy July 27, 2023 03:38
ChaituVR
ChaituVR approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit e77c7cf into master Jul 27, 2023
1 check passed
@ChaituVR ChaituVR deleted the fix-CI branch July 29, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

@Todmy Todmy Awaiting requested review from Todmy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR