Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add build workflow #620

Merged
merged 3 commits into from
Jul 28, 2023
Merged

chore: add build workflow #620

merged 3 commits into from
Jul 28, 2023

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jul 27, 2023

🧿 Current issues / What's wrong ?

The current production app is run directly with ts-node on typescript file, instead of with node on compiled js files.

This result in 10x more memory consumption.

My guess is that that solution was retained because the build workflow (tsc) does not copy the gql file to the final build directory.

💊 Fixes / Solution

  • Run production app with node instead of ts-node

🚧 Changes

  • Build files and run the production app with node command
  • Add a post-build task to copy the gql file to the build directory

🛠️ Tests

  • Run yarn build
  • Run yarn start
  • It should start the app

@wa0x6e wa0x6e requested a review from ChaituVR July 27, 2023 09:30
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #620 (a2c06b4) into master (5fa52a5) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #620   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          39      39           
  Lines        1696    1696           
  Branches       39      39           
======================================
  Misses       1657    1657           
  Partials       39      39           

@wa0x6e wa0x6e merged commit 1a440c2 into master Jul 28, 2023
4 checks passed
@ChaituVR ChaituVR deleted the run-on-compiled-code branch July 29, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants