-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return limits and remaining count in headers #634
Conversation
res.locals.keycardData = keycardData; | ||
res.set('X-Api-Key-Limit', keycardData.limit); | ||
res.set('X-Api-Key-Remaining', keycardData.remaining); | ||
res.set('X-Api-Key-Reset', keycardData.reset); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lint errors should be fixed once we install new version of keycard.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and publish the new keycard.js version first, can not even yarn dev
because of typescript error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using keycard.js from github for now. will use from npm once it is published
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 38 38
Lines 1662 1668 +6
Branches 38 38
======================================
- Misses 1624 1630 +6
Partials 38 38
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
🔴 Need a new version from snapshot-labs/keycard.js#7
Summary of changes:
How to test:
yarn link
or wait for the new version to be releasedhttp://localhost:3000/graphql?apiKey=1234
(replace apiKey if required)