Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add verified field to SpacesWhere #914

Merged
merged 3 commits into from
Aug 26, 2024
Merged

feat: add verified field to SpacesWhere #914

merged 3 commits into from
Aug 26, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Aug 23, 2024 •
edited
Loading

Closes #907

This PR add a verified filter to the spaces where argument

Test

query Spaces {
  spaces(where: { verified: true }) {
    id 
    name
  }
}

This should return a list of only verified spaces

bonustrack
bonustrack approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, this was requested by DAOStar, we should ping them once merged.

ChaituVR
ChaituVR requested changes Aug 24, 2024
View reviewed changes
src/graphql/helpers.ts Outdated Show resolved Hide resolved
@wa0x6e wa0x6e requested a review from ChaituVR August 25, 2024 05:00
ChaituVR
ChaituVR approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@wa0x6e wa0x6e merged commit 45354da into master Aug 26, 2024
2 checks passed
@wa0x6e wa0x6e deleted the feat-907-filter-spaces-by-verified branch August 26, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add filter for verified spaces
3 participants
@wa0x6e @ChaituVR @bonustrack