-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow searching space by domain #928
Conversation
There's some invalid space id in the domains.json (space id not ending .eth) |
What are those? we also support ENS names that doesn't end with |
For now, I found one ending with .io and on with .fi They're both in the sql import query, will be ignored if the space does not exist anyway |
But this query doesn't change |
Correct, wrong query, will update EDIT: Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
Don't merge until we run all queries
Toward https://github.com/snapshot-labs/workflow/issues/142
domain
column to the spaces tabledomain
to spaces where, so we could fetch a space by its domain (will look into the domain field in the space settings)The new domain column is just a "mirror" column to ensure all domains are unique (used by sequencer on saving), we will still save and fetch the domain property from the space settings.
This PR goal is to port the domains.json into the hub, and to get rid of it. This will require some manual cleaning on the database side, to make hub data match the json file, which is our source of truth.
Setup
TODO
domain
column (this is just transforming the https://github.com/snapshot-labs/snapshot-spaces/blob/master/spaces/domains.json file into sql query)domain
field in space settingsdomain
column content into space settings when not null