fix: Remove proposal check in votes query

[ChaituVR]

Fixes #760

• We don't have votes with null proposal
• Removes check for proposal in votes query

How to test

• Use this query

query ($spaceId: String!, $where: VoteWhere!, $orderDirection: OrderDirection!) {
  votes(where: $where, orderDirection: $orderDirection) {
    created
    voter
  }
  space(id: $spaceId) {
    admins
    members
    moderators
  }
}

Variables

{
  "spaceId": "arbitrumfoundation.eth",
  "where": {
    "space": "arbitrumfoundation.eth",
    "created_gt": 0
  },
  "orderDirection": "DE"
}

• It should be super slow before fix and relatively fast after fix

[bonustrack]

The id sorting is here because we've noticed that it can create duplicates and remove votes in pagination is there are multiple votes with the same timestamp

[wa0x6e]

removing the JOIN... is not enough to make the query fast ?

[ChaituVR]

removing the JOIN... is not enough to make the query fast ?

Yep, for example try running

SELECT v.* FROM votes v
    WHERE 1 = 1 AND v.space = 'arbitrumfoundation.eth'
    ORDER BY v.created DESC, v.id ASC LIMIT 0, 1

vs

SELECT v.* FROM votes v
    WHERE 1 = 1 AND v.space = 'arbitrumfoundation.eth'
    ORDER BY v.created DESC LIMIT 0, 1

[ChaituVR]

But anyway i will do seperate PR for v.id, lets merge this first.

[wa0x6e]

utAck