-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add and return spaces's colors from skins table #971
Conversation
This reverts commit 376cde0.
d0085e5
to
f14e147
Compare
f14e147
to
ef0aa8a
Compare
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
return spaces.map(space => | ||
Object.assign( | ||
space, | ||
formatSpace({ skinSettings: formatSkinSettings(space), ...space }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if it is good to call formatSkinSettings on every formatSpace
, you see some alternative?
could we call formatSkinSettings
inside formatSpace
? maybe we can add skinsettings
inside settings
object 🤔
But yea not too important
Toward https://github.com/snapshot-labs/workflow/issues/275
This PR adds a new table to hold a space's skin custom colors.
Context
Instead of having each space use a pre-defined skin, we're moving to each space having its own skin. This allow each space to customize its own skin, directly via its space settings
Create table with