Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Neon Devnet and Neon Mainnet #876

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joehquak
Copy link

This PR adds the Neon Devnet and Mainnet to Snapshot

Neon EVM was launched to public on 17th July 2023 during ETHCC

References:
Mainnet: https://chainlist.org/chain/245022934
Devnet: https://chainlist.org/chain/245022926

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #876 (661f9ec) into master (a99c3ab) will increase coverage by 3.36%.
Report is 1 commits behind head on master.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
+ Coverage   40.84%   44.21%   +3.36%     
==========================================
  Files          22       22              
  Lines        1956     1970      +14     
  Branches      173      186      +13     
==========================================
+ Hits          799      871      +72     
+ Misses       1148     1090      -58     
  Partials        9        9              
Files Changed Coverage Δ
src/utils/blockfinder.ts 97.87% <94.73%> (+82.72%) ⬆️

... and 2 files with indirect coverage changes

@joehquak
Copy link
Author

Just want to also double check that start: refers to the starting block to index from? If so then my implementation should be correct.

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joehquak We have changed our process to add new networks, refer https://docs.snapshot.org/developer-guides/networks

@joehquak
Copy link
Author

Hey @ChaituVR
Just submitted 2 requests, one for each network

Just an FYI, the IPFS field doesn't accept ipfs:// addresses, I had to use a https:// address via cloudflare

Thanks

@ChaituVR
Copy link
Member

Hey @joehquak To support these networks the network request should be coming from the Neon EVM team itself

@joehquak
Copy link
Author

Hey @joehquak To support these networks the network request should be coming from the Neon EVM team itself

Hi @ChaituVR I'm a partner of Neon however if you like I can get one of the team members to comment on this PR?

@ChaituVR
Copy link
Member

ChaituVR commented Aug 1, 2023

Better to respond directly on the form in docs, they can add dummy data on network fields, I will merge these both requests into one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants