Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display statement source #649

Merged
merged 7 commits into from
Aug 28, 2024
Merged

feat: display statement source #649

merged 7 commits into from
Aug 28, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Aug 22, 2024 •
edited
Loading

Summary

Toward https://github.com/snapshot-labs/workflow/issues/167

This PR show the statement source when available

How to test

  1. Go to http://localhost:8080/#/sn:0x009fedaf0d7a480d21a27683b0965c0f8ded35b3f1cac39827a25a06a8a682a4/profile/0x0ac7231Cc1994fD98F80DB1c58efBA712Fb72f1A
  2. It should show a statement, with KaramHQ specified as source in the bottom

To-Do

@wa0x6e wa0x6e marked this pull request as draft August 22, 2024 16:45
@wa0x6e wa0x6e requested a review from ChaituVR August 28, 2024 04:48
@wa0x6e wa0x6e assigned wa0x6e and unassigned wa0x6e Aug 28, 2024
@wa0x6e wa0x6e marked this pull request as ready for review August 28, 2024 04:49
ChaituVR
ChaituVR approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

apps/ui/src/views/SpaceUser/Statement.vue Outdated Show resolved Hide resolved
@wa0x6e wa0x6e requested a review from Sekhmet August 28, 2024 05:53
Sekhmet
Sekhmet approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@wa0x6e wa0x6e merged commit 518fd05 into master Aug 28, 2024
2 of 3 checks passed
@wa0x6e wa0x6e deleted the feat-add-support-for-statement-source branch August 28, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

@Sekhmet Sekhmet Sekhmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wa0x6e @Sekhmet @ChaituVR