Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std deviation in reward computation can be negative sometimes #4

Open
siddharth119 opened this issue Jun 15, 2021 · 0 comments
Open
Assignees

Comments

@siddharth119
Copy link
Collaborator

can it be ensured that the std deviation cannot be negative? this throws an error in line 63 of reward_model.py.

this is an edge case as the reward should never be negative but sometimes the opt problem can generate a flow of -0.00 and we want to be robust to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants