Add reference to redis projects; remove need for json constructors in redis project; do not process saga actions on completed sagas #42
Conversation
Merge snatch-dev -> rangerlabs
Develop -> Master
|
@GooRiOn Hey, I know you're busy with DevMentors and all, could you take a look at this when you get time? I'm open to feedback on it. I'm using it in production and have a few other enhancements I could add but I'm afraid they won't get merged. This PR fixes some necessary project references as well. I'm using EF Core as the Saga Log and Saga State store for my implementation. I think that would be very useful for a lot of .Net devs and I can add that sometime soon. |
| @@ -53,7 +53,7 @@ internal sealed class SagaCoordinator : ISagaCoordinator | |||
| { | |||
| var (isInitialized, state) = await _initializer.TryInitializeAsync(saga, id, message); | |||
|
|
|||
| if (!isInitialized) | |||
| if (!isInitialized || state.State is SagaStates.Completed) | |||
There was a problem hiding this comment.
Just a note, this is useful to avoid redundant processing. Some sagas may require interaction from a user outside of the normal flow - like clicking on a link in an e-mail, which they could do multiple times. I couldn't think of a case where one would want to process a message for a saga after it has already been marked Completed.
No description provided.