Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dashprivate props #458

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

AnnMarieW
Copy link
Collaborator

@AnnMarieW AnnMarieW commented Dec 12, 2024

Close #453

When updates were made in Dash PR#3066 to address #390, _dashprivate props were removed. This PR updates to remove these props from dmc.

  • Checkbox - update function to handle custom icons in checkboxes
  • Popover
  • Menu
  • Hovercard
  • Timeline
  • Stepper
  • Anchor - This component uses _dashprivate_pushstate. Confirmed that it's OK to use this private variable. It enables the dmc.Anchor to work like the dcc.Link component with the dcc.Location component. See 3066 comment
  • Skeleton. This component isn't working but neither is dcc.Loading currently.

Note - Test pass locally when using the dash version from PR 3066

Todo - maybe another PR:

@AnnMarieW
Copy link
Collaborator Author

Checkbox test app

import dash_mantine_components as dmc
from dash import Dash, _dash_renderer, Input, Output, State
_dash_renderer._set_react_version("18.2.0")
from dash_iconify import DashIconify

app = Dash(external_stylesheets=dmc.styles.ALL)

component = dmc.Stack([
    dmc.Checkbox(
        label="Custom checked icon",
        checked=True,
        icon=DashIconify(icon="ion:bag-check-sharp"),
        size="lg",
        p=0,
    ),
    dmc.Checkbox(
        label="Custom intermediate icons",
        indeterminate=True,
        indeterminateIcon=DashIconify(icon="material-symbols:indeterminate-question-box"),
        size="lg"
    )
])

app.layout = dmc.MantineProvider(
    component
)

if __name__ == "__main__":
    app.run(debug=True)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using dashprivate props
1 participant