-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: fb missing artist #72
Conversation
Could you explain how does it break? Is there an exception thrown or it simply doesn't find the title you are looking for? |
The code works fine however, if the artist field is empty the query sent to bandcamp looks like this: ' - track title'. This won't return any results even if the track is present on bandcamp probably because their search assumes the title of the track to contain the dash if nothing is in front of it. |
This makes sense, thank you! Not ideal indeed. Regarding the change, see the comments I added the other day 🙂 |
Yes I saw them but did not have the time then to get to it right away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for sorting this out!
Just found that my alterations to the search (#68) break if the artist is empty (bandcamp search can't handle ' - title' syntax in search). This fixes the issue. I did not include a changelog entry as this feature has not been released yet and is already present in the log.