Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: fb missing artist #72

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

whatphilipcodes
Copy link

@whatphilipcodes whatphilipcodes commented Oct 24, 2024

Just found that my alterations to the search (#68) break if the artist is empty (bandcamp search can't handle ' - title' syntax in search). This fixes the issue. I did not include a changelog entry as this feature has not been released yet and is already present in the log.

@snejus
Copy link
Owner

snejus commented Oct 27, 2024

break if the artist is empty (bandcamp search can't handle ' - title' syntax in search)

Could you explain how does it break? Is there an exception thrown or it simply doesn't find the title you are looking for?

beetsplug/bandcamp/__init__.py Outdated Show resolved Hide resolved
beetsplug/bandcamp/__init__.py Outdated Show resolved Hide resolved
beetsplug/bandcamp/__init__.py Outdated Show resolved Hide resolved
@whatphilipcodes
Copy link
Author

The code works fine however, if the artist field is empty the query sent to bandcamp looks like this: ' - track title'. This won't return any results even if the track is present on bandcamp probably because their search assumes the title of the track to contain the dash if nothing is in front of it.

@snejus
Copy link
Owner

snejus commented Oct 29, 2024

The code works fine however, if the artist field is empty the query sent to bandcamp looks like this: ' - track title'. This won't return any results even if the track is present on bandcamp probably because their search assumes the title of the track to contain the dash if nothing is in front of it.

This makes sense, thank you! Not ideal indeed. Regarding the change, see the comments I added the other day 🙂

@whatphilipcodes
Copy link
Author

Yes I saw them but did not have the time then to get to it right away.
Should be all included now :)

Copy link
Owner

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for sorting this out!

@snejus snejus merged commit 5f90747 into snejus:main Oct 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants