Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

OAuth is always redirecting to localhost #49

Closed
schettn opened this issue May 6, 2020 · 0 comments · Fixed by #51 or #78
Closed

OAuth is always redirecting to localhost #49

schettn opened this issue May 6, 2020 · 0 comments · Fixed by #51 or #78
Assignees
@schettn @pinterid
Labels
bug Something isn't working
Milestone
DA Start

Comments

@schettn
Copy link
Member

schettn commented May 6, 2020

Describe the bug
OAuth util has implemented a switch which recognises whether you are on localhost or not.
The correct config detail is chosen accordingly. That doesn't work correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://snek.at'
  2. Click on 'Software Engineer'
  3. Click on the GitHub icon and sign in
  4. See error

Expected behavior
The Github redirect should work on snek and localhost.

Screenshots
telegram-cloud-photo-size-4-5877248843328893730-y

Desktop (please complete the following information):

  • OS: MacOS, windows
  • Browser: safari, chrome

Additional context

  • Ref: 🐍
@schettn schettn added the bug Something isn't working label May 6, 2020
@schettn schettn added this to the DA Start milestone May 6, 2020
@schettn schettn mentioned this issue May 6, 2020
Merged
6 tasks
@schettn schettn linked a pull request May 6, 2020 that will close this issue
Intel quicky 2 to implement 1 #51
Merged
6 tasks
@pinterid pinterid closed this as completed May 7, 2020
@pinterid pinterid mentioned this issue Jun 6, 2020
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@schettn schettn

@pinterid pinterid

Labels
bug Something isn't working
Projects
None yet
Milestone
DA Start
Development

Successfully merging a pull request may close this issue.

Intel quicky 2 to implement 1 snek-at/intel
Implement 1 to master (v0.1.0) snek-at/intel
2 participants
@schettn @pinterid