Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Intel quicky 2 to implement 1 #51

Merged
merged 8 commits into from
May 7, 2020
Merged

Intel quicky 2 to implement 1 #51

merged 8 commits into from
May 7, 2020

Conversation

schettn
Copy link
Member

@schettn schettn commented May 6, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • Ref: 🐍

schettn added 7 commits May 6, 2020 14:30
@schettn
Improve code quality
32fd351 
Some whitespaces have been removed.
Now there is a new line between extern and intern
imports.
@schettn
Update OAuth config
3584df2 
The snek's clientId and clientSecrete have been
added to the deploy mode.
@schettn
Fix OAuth window location bug
16a4f30 
Now the config detail switch is working.
@schettn
Modify model name-table name mapping
9f62c77 
More information about these modifications can be found here:
Ref: #50
@schettn
Add organisation check to Github converter
aa14514 
If access rights to an organisation are too low, the content of the respective node is empty. A check has been added to prevent errors.
@schettn
Add type declaration in the converters
2ac242c 
Now the type declaration for platform has been added in both converters.
@schettn
Enhance asynchronous code performence
b643efc 
More information about these changes can be found here:
Ref: https://github.com/snek-at/front/issues/145
@schettn schettn added the bug Something isn't working label May 6, 2020
@schettn schettn added this to the DA Start milestone May 6, 2020
This was linked to issues May 6, 2020
OAuth is always redirecting to localhost #49
Closed
The OSM is not working with JavaScript compression #50
Closed
Aichnerc
Aichnerc approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Here is a cake for solving the issue. 🎂

pinterid
pinterid approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to merge

kleberbaum
kleberbaum suggested changes May 7, 2020
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge after a few changes.

@schettn
Improve code quality
218b222 
The code quality has been improved due to a
request of @kleberbaum.
@schettn schettn requested a review from kleberbaum May 7, 2020 09:25
kleberbaum
kleberbaum approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

@kleberbaum kleberbaum merged commit 978a368 into implement-1 May 7, 2020
@pinterid pinterid mentioned this pull request Jun 6, 2020
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Aichnerc Aichnerc Aichnerc approved these changes

@kleberbaum kleberbaum kleberbaum approved these changes

@pinterid pinterid pinterid approved these changes

Assignees

@schettn schettn

@pinterid pinterid

Labels
bug Something isn't working
Projects
None yet
Milestone
DA Start
Development

Successfully merging this pull request may close these issues.

The OSM is not working with JavaScript compression OAuth is always redirecting to localhost
4 participants
@schettn @Aichnerc @kleberbaum @pinterid