Skip to content

Commit

Permalink
deps: bump golangci-lint version to 1.62 in GH actions (microsoft#1096)
Browse files Browse the repository at this point in the history
# Description

Bump version of golangci-lint used in GH actions to 1.62

## Related Issue

Fix for false positive typecheck error in
microsoft#962 (comment)

## Checklist

- [x] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [x] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [x] I have correctly attributed the author(s) of the code.
- [x] I have tested the changes locally.
- [x] I have followed the project's style guidelines.
- [x] I have updated the documentation, if necessary.
- [x] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

N/A

## Additional Notes

N/A

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.

---------

Signed-off-by: Will Daly <[email protected]>
  • Loading branch information
wedaly authored Dec 3, 2024
1 parent b801f4a commit ebca883
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
if: env.IS_NOT_MERGE_GROUP
uses: golangci/golangci-lint-action@v6
with:
version: v1.55
version: v1.62
args: --concurrency 4 --verbose --config=.golangci.yaml --timeout=25m
only-new-issues: true
skip-cache: true
6 changes: 3 additions & 3 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ issues:
- path: pkg/metrics/types_windows.go
linters:
- revive
- gomnd
- mnd
- var-naming
- path: pkg/metrics/types_linux.go
linters:
- revive
- gomnd
- mnd
- var-naming
linters:
presets:
Expand All @@ -31,7 +31,7 @@ linters:
- gocritic
- gocyclo
- gofmt
- gomnd
- mnd
- goprintffuncname
- gosimple
- lll
Expand Down
2 changes: 1 addition & 1 deletion pkg/plugin/linuxutil/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ MOCKGEN = $(TOOLS_BIN_DIR)/mockgen
.PHONY: generate

generate: $(MOCKGEN) ## Generate mock clients
$(MOCKGEN) -source=$(REPO_ROOT)/pkg/plugin/linuxutil/types_linux.go -copyright_file=$(REPO_ROOT)/pkg/lib/ignore_headers.txt -package=linuxutil > linuxutil_mock_generated.go
$(MOCKGEN) -source=$(REPO_ROOT)/pkg/plugin/linuxutil/types_linux.go -copyright_file=$(REPO_ROOT)/pkg/lib/ignore_headers.txt -package=linuxutil > linuxutil_mock_generated_linux.go

$(MOCKGEN):
@make -C $(REPO_ROOT) $(MOCKGEN)

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/plugin/linuxutil/types_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const (
Name api.PluginName = "linuxutil"
)

//go:generate go run go.uber.org/mock/[email protected] -source=types_linux.go -destination=linuxutil_mock_generated.go -package=linuxutil
//go:generate go run go.uber.org/mock/[email protected] -source=types_linux.go -destination=linuxutil_mock_generated_linux.go -package=linuxutil
type linuxUtil struct {
cfg *kcfg.Config
l *log.ZapLogger
Expand Down

0 comments on commit ebca883

Please sign in to comment.