Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed zerofill_count field being ignored during set up #16081

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Fixed zerofill_count field being ignored during set up #16081

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96379d0
Use provided zerofill_count
marcusmoore Jan 16, 2025
4b2ede7
Use 0 for zerofill_count if nothing provided
marcusmoore Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/Http/Controllers/SettingsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ public function postSaveFirstAdmin(SetupUserRequest $request) : RedirectResponse
$settings->next_auto_tag_base = 1;
$settings->auto_increment_assets = $request->input('auto_increment_assets', 0);
$settings->auto_increment_prefix = $request->input('auto_increment_prefix');
$settings->zerofill_count = $request->input('zerofill_count') ?: 0;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just:

$settings->zerofill_count = $request->input('zerofill_count', 0);

would work, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too but when I tried it the result of the function was null which triggered an exception.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how we set defaults when no value has been passed everywhere else though. 🤔 I don't see why it wouldn't work here as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I figured it out.

These are checkboxes on the front end and if they are unchecked the browser does not include them in the payload:

$settings->full_multiple_companies_support = $request->input('full_multiple_companies_support', 0);
$settings->auto_increment_assets = $request->input('auto_increment_assets', 0);

This is a text input so the browser always includes it but Laravel sets it to null if nothing was input:

$settings->zerofill_count = $request->input('zerofill_count', 0);

So it ends up using null because it is in the request.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, and it looks like that db field is not nullable, hence the error


if ((! $user->isValid()) || (! $settings->isValid())) {
return redirect()->back()->withInput()->withErrors($user->getErrors())->withErrors($settings->getErrors());
Expand Down
Loading